[MPlayer-dev-eng] Re: Why is the mplayer-1.0pre3-dumpvideo.diff patch not applied?

[John Earl]

Revised patch attached - any other comments?

Tobias Diedrich wrote:
> John Earl wrote:
>>Sorry, didn't think the patch would be wanted! There was already an 
>>online help string (using -of help) but have added a couple lines to the 
>>man page in new version, attached.
> 
> 
> I think rawvideo would be a better name. :-)
> And I think I'm probably not the only one who will find this patch
> useful, especially for mpeg encoding scripts.

I agree. Done.

Have you actually tried it to make sure it does what you expect with 
compressed streams? (I'm only using it with -of rawvideo -ovc raw)

>>+static void write_raw_chunk(FILE *f,int len,void* data){
>>+    if(len>0){
>>+	if(data){
>>+	    // DATA
>>+	    fwrite(data,len,1,f);
>>+	} else {
>>+	    // JUNK
>>+	    char *avi_junk_data="[= MPlayer junk data! =]";
>>+	    if(len&1) ++len; // padding
>>+	    while(len>0){
>>+		int l=strlen(avi_junk_data);
>>+		if(l>len) l=len;
>>+		fwrite(avi_junk_data,l,1,f);
>>+		len-=l;
>>+	    }
>>+	}
>>+    }
>>+}
> 
> 
> You can drop the junk path.

The attached patch loses the junk path as suggested.

>>+    if((unsigned int)len>s->h.dwSuggestedBufferSize) s->h.dwSuggestedBufferSize=len;
> 
> 
> This line should be unneeded too.

Ok, done. I wasn't careful enough to work out where else 
dwSuggestedBufferSize might be used.

J
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-rawmux.patch
Type: text/x-patch
Size: 8014 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040223/f05b48e8/attachment.bin>