[MPlayer-dev-eng] vo_sdl flags patch

[John Philip]

Hello, I was browsing mplayer's SDL video-out code, and noticed the 
flags were incorrect.

First, It was using the flag SDL_HWACCEL, which is not legal to be 
passed to SDL_SetVideoMode() -- SDL_HWACCEL is a read-only flag set by 
SDL in the 'flags' field of an SDL_Surface structure. (ref: 
http://sdldoc.csn.ul.ie/sdlsurface.php )

Second, it was using the flag SDL_ASYNCBLIT, which "Enables the use of 
asynchronous updates of the display surface. This will usually slow 
down blitting on single CPU machines, but may provide a speed increase 
on SMP systems." (ref: http://sdldoc.csn.ul.ie/sdlsetvideomode.php )

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SDLflags.patch
Type: application/octet-stream
Size: 1632 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040213/8910d130/attachment.obj>
-------------- next part --------------


Now, I wasn't totally sure about  the second one, the SDL_ASYNCBLIT 
flag. Conceivably mplayer may benefit from asynchronous updates of the 
display surface, despite the SDL documentation's warnings of it's 
inefficiency on single processor machines. If someone who knows the 
workings of mplayer and it's interaction with SDL better than I thinks 
so, I made a patch without the SDL_ASYNCBLIT changes.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SDLflags_hwsurfaceonly.patch
Type: application/octet-stream
Size: 1288 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040213/8910d130/attachment-0001.obj>
-------------- next part --------------


Thanks for your time
And apologies if I'm breaking protocol, I've not done this before.
John