[MPlayer-dev-eng] [PATCH] OpenDML AVI2.0 read support

[Arpi]

Hi,

> D Richard Felker III writes:
>  > On Fri, Feb 06, 2004 at 05:51:14PM -0500, The Wanderer wrote:
>  > > Should the printf() calls be changed in things like libavcodec,
>  > > libfaad2, mp3lib and so forth?
>  > 
>  > Yes, most certainly! Any lib that calls printf is just plain broken.
>  > stdout does not belong to libs!!
> 
> This would be against current policy as I understand it.  External
> libs should be modified as little as possible to make syncing to newer
> versions easier.  AFAIK mp_msg is only used in our internal libs
> because of this and a quick grep through the sources confirms this...

Sure. Any code syncronized to external code/source ("upstream") should
not be modified at all, or at the very minimum rate (the required
changed to compile/work in mplayer tree, as unmodified libs arent
in mplayer tree at all)

mp3lib is a good question, some parts of it were developed in/for
mplayer, only layer*.c and a few .h files and tables come from mpg123.
since mpg123 is not developed for years, it may be changed if needed.

but for libmpdvdkit, libavcodec, liba52, libmpeg2, libdha/vidix, libfaad2
shouldn't be changed.


A'rpi / Astral & ESP-team

--
Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu