[MPlayer-dev-eng] [PATCH] OpenDML AVI2.0 read support

The Wanderer inverseparadox at comcast.net
Fri Feb 6 22:26:46 CET 2004


Attila Kinali wrote:

> On Fri, 6 Feb 2004 16:09:51 +0100 (CET)
> Tilmann Bitterberg <transcode at tibit.org> wrote:
> 
>>Here is an updated version of the patch (fixes a few bugs)
>>Tested with a 5.4 GB AVI file:
> 
> I just had a very quick look at it.
> Please change the printfs to mp_msg calls.

Apropos of this: as of this morning's CVS, there are (depending on which
way you count it - I haven't been able to put together a reliable
regular expression which doesn't return false positives) between several
hundred and a few thousand printf() calls under the MPlayer source tree,
not counting any from libavcodec. Given stated policy, I'd like to ask
if there is any reason - other than "no one noticed enough to point it
out" - why these made it in without being changed to mp_msg() or similar
calls? For that matter, would there be any problem with changing them,
if someone wanted to do the work of tracking them all down?

-- 
       The Wanderer, sticking his neck out a lot these days

A government exists to serve its citizens, not to control them.




More information about the MPlayer-dev-eng mailing list