[MPlayer-dev-eng] [PATCH] Display framedropping state in the OSD

[D Richard Felker III]

On Thu, Feb 05, 2004 at 11:21:14PM -0300, Diego Biurrun wrote:
> Hi!
> 
> After being (rightly) accused by Gabucino of fixing (only?) bugs that
> nobody complains about I sulked for a day and decided to come up with
> something useful.  The attached patch is the closest I could come,
> whatever that may mean.
> 
> I noticed that the "d" key toggles frame dropping, but gives no visual
> feedback on the OSD, unlike similar keys that toggle, e.g. subtitle
> visibility and similar stuff.  The attached patch fixes this and
> displays
> 
>   Framedropping: [on|hard|off]
> 
> on the OSD depending on whether framedrop, hardframedrop or no
> framedrop is currently enabled.

ROTFL!!! WTF do you think happens if the video is already playing too
slow, and the user hits "d" to turn on framedrop and all the sudden
osd appears? :) Yep, you guessed it! It gets even slower!

In some ways the feature makes sense, yes....but it also could be
really counter-productive. Even worse would be when switching
framedrop back _off_, since then you can't drop frames to make up for
the slowdown of osd, so a/v will desync...

Rich