[MPlayer-dev-eng] [PATCH] directx -wid support

Joey Parrish joey at nicewarrior.org
Tue Dec 21 21:37:54 CET 2004


On Tue, Dec 21, 2004 at 04:24:41PM +0100, Sascha Sommer wrote:
> On Thursday 16 December 2004 13:50, Joey Parrish wrote:
> > This patch adds support for -wid to vo_directx.
> >
> > Important notes:
> >   * -wid for directx is a window handle as returned by a call to
> >     FindWindow in the win32 api.  VOCTRL_{ONTOP, ROOTWIN} have no
> >     effect when an external window is being used.  fullscreen still
> >     works.
> >
> >   * -geometry, when used with -wid, will specify a location relative
> >     to the window rather than the screen.  this is useful for embedding
> >     MPlayer into a frontend or browser.
> >
> >   * when using -wid, MPlayer doesn't receive window system events to
> >     tell it when the window has moved.  so, Directx_ManageDisplay() is
> >     called to calculate the position of the window.  this has not
> >     impacted performance in my tests.  also note that calculating the
> >     new values for the RECT structure takes the same exact calls as you
> >     would use to simply detect the movement of the window.  so no, it
> >     would not be better to check for movement and only call ManageDisplay()
> >     when it's moved.
> >
> > This patch depends on the last two I've sent, (colorkey and monitoraspect)
> > but only because I diff'd the tree in that order.  I've attached them for
> > convenience in testing.
> >
> > Comments?  I'd like to commit this soon.
> >
> 
> Just wrote a small app to test this feature. Works really nice.
> Feel free to commit whenever you find the time for it.
> It would really rock if there was a firefox plugin for windows MPlayer ;)

Committed.

--Joey

-- 
"The tide is turning... the enemy is suffering terrible losses..."
  --Gen. Custer




More information about the MPlayer-dev-eng mailing list