[MPlayer-dev-eng] [PATCH] -- FreeBSD RTC Support

[Diego Biurrun]

Michael Johnson writes:
> On Dec 19, 2004, at 7:44 AM, Diego Biurrun wrote:
> 
> > Michael Johnson writes:
> >
> >> On Dec 18, 2004, at 11:54 AM, Diego Biurrun wrote:
> >>
> >>> Hmm, there is already a "patch" in the FreeBSD ports tree that 
> >>> enables
> >>> RTC on FreeBSD (at the cost of dropping Linux support, though). It
> >>> looks so much simpler, does it work for you? I've pasted the relevant
> >>> hunk below.
> >>>
> >>> --- configure.orig Thu Jul 15 00:04:42 2004
> >>> +++ configure Thu Jul 22 22:13:22 2004
> >>> @@ -4670,11 +4617,11 @@
> >>>
> >>>
> >>>  echocheck "RTC"
> >>> -if linux ; then
> >>> +if freebsd ; then
> >>>  if test "$_rtc" = auto ; then
> >>>  cat > $TMPC << EOF
> >>>  #include <sys/ioctl.h>
> >>> -#include <linux/rtc.h>
> >>> +#include <rtc.h>
> >>>  int main(void) { return RTC_IRQP_READ; }
> >>>  EOF
> >>>  _rtc=no
> >>>
> >> I submitted that patch about a year ago. and yea it works =)
> >>
> >> but every time configure changes the patch will have to be updated
> >> and there is some parts in Makefile that change a few options in
> >> configure and mplayer.c, I just think it would be nice to add this
> >> to mplayer so people can use snapshots with RTC and not have to
> >> patch mplayer.
> >>
> > There is a misunderstanding here.. My question was why you submitted
> > a patch that is so much more complicated and intrusive than what is
> > available in the ports tree. If the FreeBSD port supports RTC, I'd
> > say clean up the patch to configure and let us use that instead.
> >
> so it still supports linux mainly. it won't work on linux with the 
> patch we have in FreeBSD currently. Michael

We have a complete failure to communicate.  Please answer "yes" or
"no" to the following question:

If you apply the patch below to vanilla MPlayer CVS, do you get RTC
support on FreeBSD?

Diego

--- configure.orig	Thu Jul 15 00:04:42 2004
+++ configure	Thu Jul 22 22:13:22 2004
@@ -4670,11 +4617,11 @@
 
 
 echocheck "RTC"
-if linux ; then
+if freebsd ; then
   if test "$_rtc" = auto ; then
     cat > $TMPC << EOF
 #include <sys/ioctl.h>
-#include <linux/rtc.h>
+#include <rtc.h>
 int main(void) { return RTC_IRQP_READ; }
 EOF
     _rtc=no