[MPlayer-dev-eng] [PATCH] [RFC] New audio filter: LADSPA plugin loader

Ivo ivop at euronet.nl
Sun Dec 19 23:15:28 CET 2004


On Monday 13 December 2004 19:10, Diego Biurrun wrote:
> Nit: trailing whitespace, also in the files you add.

Fixed. I still have to figure out how to have vissible eol's in vi/vim, but 
I'm too lazy to check the documentation :-)

> These lines are longer than 79 characters, you should break them.

[..]

> command line

Fixed.

> You end a lot of your messages in an exclamation mark "!", IMO this is
> a bit excessive.  Don't overuse it, only real warnings should use it.

I agree. I have removed most of them. Also, I checked if the line(s) need a 
full-stop or not and hopefully did it right :)

I'll post a new patch later tonight.

--Ivo




More information about the MPlayer-dev-eng mailing list