[MPlayer-dev-eng] [PATCH]: move vo_subdevice before subopt parser

Daniele Forghieri guru at digitalfantasy.it
Fri Dec 17 10:14:41 CET 2004


Taking a look at the various video output module to document the 
suboption i found that some vo's don't use  the parameter args passed 
from the init_best_video_out(...) function but directly the variable 
vo_subdevice (that is global).

This patch make the vo_subdevice local to the function, drop the 
declaration of the variable in the .h and in some .c and change the 
function that uses it directly.

May be is good to apply this patch before working on the subopt parser 
(or maybe is better to integrate it directly in the final patch that 
handles the subopt).

BTW some vo's uses the function arg but the name is vo_subdevice (as the 
global var).

The audio output modules use the global var ao_subdevice, it's a good 
thing make them work like the video modules (with the subdevice passed 
at the init function) ?

    Daniele Forghieri

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: drop_vo_subdevice.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041217/19b479f5/attachment.asc>


More information about the MPlayer-dev-eng mailing list