[MPlayer-dev-eng] [PATCH] directx -colorkey support

Diego Biurrun diego at biurrun.de
Thu Dec 16 17:53:53 CET 2004


On Thu, Dec 16, 2004 at 06:38:03AM -0600, Joey Parrish wrote:
> 
> Attached is a very simple patch to support the -colorkey option in
> vo_directx.

Looks simple indeed..

> I will commit in a couple of days if there are no objections.

I object!

> @@ -978,6 +987,7 @@
>      monitor_rect.right=GetSystemMetrics(SM_CXSCREEN);
>      monitor_rect.bottom=GetSystemMetrics(SM_CYSCREEN);
>  	
> +    windowcolor = vo_colorkey;
>      wc.style         =  CS_HREDRAW | CS_VREDRAW;
>      wc.lpfnWndProc   =  WndProc;
>      wc.cbClsExtra    =  0;

Why do you break Sascha's prettyprinting?  Align the "="...

SCNR ;-)

Diego




More information about the MPlayer-dev-eng mailing list