[MPlayer-dev-eng] [PATCH] seekbar support for mp4 files

Jérôme Petazzoni jp at enix.org
Thu Dec 16 13:22:17 CET 2004


>New patch policy says that all functions have to be documented with
>doxygen-compatible comments. Please add that for the two functions
>you've added.
>  
>
I added a doxygen-style header for demux_mov_info, but I don't know the 
exact interface of demux_mov_control so I can't decently comment it.

>Please make sure that you never do a division by zero. 
>
I added a couple of checks, thanks.

>Your patch has leading whitespace on some lines. Please remove those
>whitespaces.
>  
>
Done too. I hope my identation is close enough of the original one 
(which is quite different from file to file, by the way :-))

Best regards,
Jérôme Petazzoni <jp at enix dot org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov-demux-seekbar.diff
Type: text/x-patch
Size: 3749 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041216/e6ce3b2a/attachment.bin>


More information about the MPlayer-dev-eng mailing list