[MPlayer-dev-eng] [PATCH] clean and cross-compilation

[Diego Biurrun]

Ivan Kalvachev writes:
> On Tue, 24 Aug 2004 22:15:47 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > Kenny (Constantine Shulyupin) writes:
> > > 
> > > --- ../MPlayer-1.0pre5.orig/libmpcodecs/Makefile	2004-06-24 16:54:07.000000000 +0300
> > > +++ ./libmpcodecs/Makefile	2004-08-24 18:42:37.000000000 +0300
> > > @@ -66,6 +66,7 @@
> > >  
> > >  clean:
> > >  	rm -f *.o *.a *~
> > > +	cd native; rm -f *.o *.a *~
> > 
> > Looks, OK, dunno if
> > 
> >   rm -f native/*.o native/*.a native/*~
> > 
> > wouldn't be better, though.
> 
> The rest of this patch have been rejected and later an better fixes have been done.
> But I don't see where libmpcodecs/native is cleaned.
> So Diego would you commit your modified version of the patch?

Committed.

> p.s.
> Why are *~ removed? I think they are backup files
> usually left by text editors. I mean clean it part of rebuild
> that is done on testing changes. If these changes are not successful
> I may need the backup files. No?

make clean removes them everywhere, so I kept it in this part of the
build system for consistency reasons.  IMO distclean should always
remove backup files, whether clean should do it as well is debatable.

Diego