[MPlayer-dev-eng] [PATCH] [try2] -wid: get initial window geometry

[Alexander Strasser]

Ivan Kalvachev wrote ( On Thu, Dec 09, 2004 at 05:02:13AM +0200 ):
> On Sun, 17 Oct 2004 17:03:22 +0200
> Attila Kinali <attila at kinali.ch> wrote:
> 
> > On Fri, 17 Sep 2004 03:28:38 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > kiriuja writes:
> > > > Updated patch, compiles against the current CVS.
> > > > 
> > > > The patch would help avoid unnecessary flicker in MPlayer frontends that use
> > > > the -wid option.
> > > 
> > > Ivan, beastd, could you check and apply this?
> > 
> > Yes, could someone check this ?
> 
> I haven't tested the patch, but I don't see any reason not to
> be applied. At least the changes appear in if(win_id) block so
> there is no way to affect normal functionality.
> 
> Beastd take a look please.

Seems ok for xv and x11. Tested it a bit and the behaviour introduced
by this patch is imho better and more consistent.

For what to do about the others, i'm not sure. I don't think Attila
has time for reviewing the changes and the other one no idea.

I can take a look at the other parts too, but don't expect it earlier
than in a week. I don't think i can even test all of them, so for
some i can at most only review the code with my imagination.

At least i could apply the changes for vo xv and vo x11.
But it think if the others have bugs and it fairly seems so,
they should be fixed too ( mplayer vos are inconsistent enough ).

  Alex (beastd)