[MPlayer-dev-eng] kerneltwosix.h crap

ismail dönmez ismail.donmez at gmail.com
Fri Dec 3 20:19:36 CET 2004


On Fri, 3 Dec 2004 10:55:21 -0500, D Richard Felker III
<dalias at aerifal.cx> wrote:
> can you tell me if it's still needed for 2.6 kernels? imo it's not.
I am not sure but I agree it shouldn't be needed anymore

> it's definitely _incorrect_ to #define __KERNEL__ in non-kernel code,
> and this is why it's breaking for lots of users now, but i'm aware
> that it was to workaround buggy fbdev kernel headers that failed to
> define the proper structs/constants/whatever when __KERNEL__ was not
> defined.
Yes kernel headers in userspace sucks.


> 
> anyway, is it still needed? i'd be happy to add #if KERNEL_VERSION ...
> stuff around it rather than removing it entirely if you can tell me
> what versions need this hack.

Let's just remove it people can update their headers if they have buggy version.

Cheers,
ismail


-- 
Time is what you make of




More information about the MPlayer-dev-eng mailing list