[MPlayer-dev-eng] Re: [PATCH] don't skip first mp3 frame

[D Richard Felker III]

On Wed, Dec 01, 2004 at 12:46:19PM +0100, Michael Behrisch wrote:
> On Thu, Oct 21, 2004 at 01:05:08PM -0400, D Richard Felker III wrote:
> > On Thu, Oct 21, 2004 at 06:36:08PM +0200, Reimar Döffinger wrote:
> > > > > See libmpcodecs/ad_mp3lib.c, line 49. I think there were/are some broken
> > > > > MP3 encoders that create only trash for the first frame or something
> > > > > like that...
> > > > 
> > > > no, the idiotic demuxer was starting at the wrong place in the file
> > > > making the decoder see the wrong data as the "first frame"... there's
> > > > no other decoder that has to discard the first frame when playing
> > > > mp3s, so mplayer shouldn't have to do it either...
> > > 
> > > So the questions is: Does the demuxer now work correctly? Should this be
> > > removed?
> > 
> > afaik, yes, the patch was committed. i'm not positive though..
> 
> The demuxer works (at least for me). I also vote for removing
> the code which kills the first frame (patch attached).

i support this change! (btw skipping this frame could cause slight a/v
desync when reencoding, or nonsense video framedropping)

rich