[MPlayer-dev-eng] Re: [xine-devel] Re: Likely (minor) bug in Real RTSP/RDT demuxing code

[Miguel Freitas]

Hi Diego,

On Tue, 31 Aug 2004 04:19:05 +0200, Diego Biurrun <diego at biurrun.de> wrote:
> >>I noticed the following line:
> >>      size=(header[1]<<12)+(header[2]<<8)+(header[3]);
> >>
> >>Although I don't know much about Real's protocol, it seems likely that this
> >>should really be:
> >>      size=(header[1]<<16)+(header[2]<<8)+(header[3]);
> >>
> >>i.e., 16 instead of 12.
> >>
> >>This becomes an issue only if the chunk size is >65535, which is probably
> >>why noone noticed it before.
> 
> Hmm, no reaction?  Is this a bug or not?

Ops, sorry for the late reply. I think we cannot really say whether
this is a bug or not since the protocol was (afaik) reverse
engineered. And since chunk size >65535 is quite unlikely to have ever
been  seen on the wire, this byte was probably zero all the time
during sniffer sessions.

Still, i personally agree with Ross. I guess we should apply this.

regards,

Miguel