[MPlayer-dev-eng] [PATCH] initial DragonFly BSD support

Joey Parrish joey at nicewarrior.org
Mon Aug 30 18:34:20 CEST 2004


On Mon, Aug 30, 2004 at 12:39:47PM +0200, Diego Biurrun wrote:
> Pawel Biernacki writes:
> > 
> > On Sun, 29 Aug 2004, Diego Biurrun wrote:
> > 
> > > Then why not test for DragonFly in configure and #define __FreeBSD__ in
> > > config.h if DragonFly is detected?
> > 
> > Becasue IMO this is not a solution to do
> > #ifdef _Some_OS_
> > #define 
> > _Some_Other_OS_Which_We_Already_Have_Because_We_Dont_Want_To_Patch_Out_Src_
> > #endif
> > 
> > And #ifdef' don't resolve problem with lrint.
> 
> Sure, but your patch would shrink to just those few instances where
> lrint would have to be defined.

An lrint implementation should go into osdep IMHO.
Also, has anyone tried making some #def BSD for BSD systems in general?
It seems in many places there is code like:

#if defined(BSD_01) || defined(BSD_02) || ... || defined(BSD_FF)
...
#endif

--Joey

-- 
"I eat donuts for dying children." --Andrew




More information about the MPlayer-dev-eng mailing list