[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc.), second patches

[The Wanderer]

The Wanderer wrote:

> Attila Kinali wrote:
> 
>> On Wed, Aug 18, 2004 at 04:57:58PM -0400, The Wanderer wrote:
>>
>>> A little more work on the conversion. These patches cover
>>> mplayer.c, and assume that the syntax-change patch from the
>>> previous set has not been applied but that the others have.
> 
>>> -  if(how) mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_Exiting,mp_gettext(how));
>>> -  mp_msg(MSGT_CPLAYER,MSGL_DBG2,"max framesize was %d  bytes\n",max_framesize);
>>> +  if(how) mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_ExitingHow,mp_gettext(how));
>>> +  mp_msg(MSGT_CPLAYER,MSGL_DBG2,MaxFramesizeWas,max_framesize);
>>
>> Please dont add DBG2+ to the help-*.h, they are of no use for the
>> casual user but create unnecessary work for the translators as
>> these messages should always be printed in english.
> 
> Acknowledged; will change, and resend (probably) shortly.

Revised patches attached; I've got the nagging feeling I've messed
something up, but I can't find anything obvious.

The recent commit, however, inadvertently broke the compile; one #define
was not committed to the help file, but its corresponding string was
replaced in mencoder.c. The help-file patch in this pair also includes
that line; if in fact the string should not be moved, that's fine, but
in that case it needs to be put back in its original place (and I should
be informed for future reference).

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mplayer_messages.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040824/96b40191/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: MSGTR_updates.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040824/96b40191/attachment.asc>