[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc.) first patches, second try

[Diego Biurrun]

The Wanderer writes:
> Diego Biurrun wrote:
> 
> > The Wanderer writes:
> > 
> >> As requested, here are the patches again, essentially identical
> >> except for revision dates (and a few line-number updates) to the
> >> versions initially posted.
> > 
> > Since Attila reviewed and OKed these patches I'll apply them if you 
> > make a few small modifications as outlined below.
> > 
> >> +#define MSGTR_CBRPCMAudioSelected "CBR PCM audio selected\n"
> > 
> > Here and below you should end complete sentences in a period.
> 
> Very well; my rule so far has been to faithfully duplicate the string
> moved, with the idea that there should be no visible difference between
> output before and after the patch, but if you want me to make
> corrections like this in the process I can certainly do so.

Hmm, let's split this into two parts maybe.  First move all the
messages to help_mp-en.h unmodified and then let's review and correct
them on the mplayer-docs mailing list.  This way we can avoid
cluttering this mailing list.

Patch applied.

> Aside from obvious typos/spelling errors, any guidelines as to what
> should or should not be changed like this? Given free rein, I'd probably
> be as likely as not to make countless nitpicky changes...

Most of the console messages could use a review for typos, wording and
ease of understanding.  There is no holy grail here, mostly everything
can be changed.

Diego