[MPlayer-dev-eng] Patch for gcc 3.4 against MPlayer-1.0pre5

Joey Parrish joey at nicewarrior.org
Mon Aug 23 10:20:07 CEST 2004


On Mon, Aug 23, 2004 at 09:36:10AM +0200, Moritz Bunkus wrote:
> > > #ifndef HAVE_LRINTF
> > > long int lrintf(float x)
> > > {
> > >   return (long int)x;
> > > }
> > > #endif
> > 
> > Should definitly be inline.
> 
> Should be correct in the first place. Casting to long int is truncating
> the value, not rounding it.

According to the original mail, this is already done in some place in
MPlayer (IIRC).  But the point is that someone should create a proper
replacement in the case of a system without one.  We should not put
code everywhere to define lrintf over and over again.

--Joey

-- 
"Are disorders necessarily bad?" --Ike




More information about the MPlayer-dev-eng mailing list