[MPlayer-dev-eng] [PATCH] automatically insert vf_expand for displaying OSD

[Joey Parrish]

On Sat, Aug 21, 2004 at 10:42:24AM +0900, Attila Kinali wrote:
> On Tue, Aug 10, 2004 at 09:51:13PM +0200, Reimar Döffinger wrote:
> > this patch automatically inserts vf_expand for displaying the OSD when 
> > the vo doesn't support it, enabling OSD for vo_gl.c. Might also allow to 
> > remove duplicate code from vo_gl2.c, vo_x11.c etc.
> 
> I dont know whether this is a good idea. expand will slowdown
> playback considerably. On the other hand, the user requested to have
> subtitles...

It inserts vf_expand when the vo doesn't support osd.  So, it slows
down playback for the vo's that don't support osd, no matter what.
These vo's are (according to grep):

> vo_3dfx.c
> vo_bl.c
> vo_cvidix.c
> vo_dxr2.c
> vo_dxr3.c
> vo_fbdev.c
> vo_fbdev2.c
> vo_gif89a.c
> vo_gl.c
> vo_jpeg.c
> vo_md5.c
> vo_mga.c
> vo_mpegpes.c
> vo_null.c
> vo_pgm.c
> vo_png.c
> vo_syncfb.c
> vo_tdfx_vid.c
> vo_tga.c
> vo_winvidix.c
> vo_xmga.c
> vo_xover.c
> vo_xvidix.c
> vo_zr.c
> vo_zr2.c

So, if vf_expand is that slow, then I retract my vote for commit.

--Joey

-- 
"Are disorders necessarily bad?" --Ike