[MPlayer-dev-eng] [PATCH] directx rootwin support
Attila Kinali
attila at kinali.ch
Sun Aug 22 01:45:50 CEST 2004
On Wed, Aug 11, 2004 at 07:27:58PM -0500, Joey Parrish wrote:
> This first patch adds -rootwin support to vo_directx. It's pretty
> simple and straightforward. I see no reason not to commit this, but
> feel free to correct me.
>
> The second patch adds VOCTRL_ROOTWIN and MP_CMD_VO_ROOTWIN to allow
> toggling rootwin at runtime. I am only adding support for this VOCTRL
> to vo_directx at the moment. I don't know whether any other vo's can
> support this or not. X11 people should look into that.
>
> Comments? Commit #1? #2 is stupid? :)
IMHO it's ok, though didnt check the code deeply.
But, you should definitly add a description about this somewhere in the
docs (dunno where that would be). It is possible to support this by x11
too, but i'd wait until Fabian finishes his 2 window fullscreen mode
patch as it would fit in nicely there.
Attila Kinali
More information about the MPlayer-dev-eng
mailing list