[MPlayer-dev-eng] Re: [PATCH] vo_xv: fix black screen in fullscreen

Attila Kinali attila at kinali.ch
Sat Aug 21 03:48:36 CEST 2004


Moin Marko,

On Wed, Aug 11, 2004 at 10:59:50PM +0200, Marko Macek wrote:
> Sorry, the previous patch had unwanted .depend diff.  New one attached.
> 
> Marko Macek wrote:
> 
> >The problem seems to be caused by a race condition between 
> >AUTOPAINT_COLORKEY
> >and this code in handle_events:
> >
> >-    if (e & VO_EVENT_EXPOSE && vo_fs)
> >-        vo_x11_clearwindow(mDisplay, vo_window);
> >
> >This sometimes causes color-key to be erased and the movie is invisible.
> >
> >The attached patch fixes this. It is careful to only paint either the 
> >background
> >(black stripes when in fullscreen) or the color-key and not both over 
> >the same pixels
> >(prevents blinking on resize). Also fixed is ugly flicker when one 
> >drags a window over
> >(lowered) fullscreen window.

Thanks for the patch. I'm currently waiting for a comment from
beastd (the current x11/xv maintainer) as he said he'll work on it.

Greetings

			Attila Kinali




More information about the MPlayer-dev-eng mailing list