[MPlayer-dev-eng] [BUG] [PATCH] DPMS left enabled after changing DVB-channel

[Attila Kinali]

On Sat, Aug 14, 2004 at 07:18:03PM +0200, David Kuehling wrote:
> there is a new bug in recent mplayer-cvs: after changing the channel in
> DVB-input, DPMS is enabled (from `vo_x11_uninit') and not disabled
> again, when the next channel comes up, resulting (for me) in a blank
> screen after some minutes.
> 
> This problem never happened for me with an earlier (approx 3 months)
> cvs-version.

I think this bug was introduced by Reimar Doeffinger on Sun, 25 Jul 2004

> You find a simple one-line patch attached that fixes the problem for me
> (moving `saver_on' from `vo_x11_uninit' to `vo_uninit').  There might,
> however be side effects, so maybe someone with better understanding
> should look at it.

IMHO that's the wrong way. All x11 modules depend on vo_x11_uninit()
to do all cleanup on the x11 side. You should rather check why dpms is
reenabled on channel switch. 

In short: Patch rejected.

			Attila Kinali