[MPlayer-dev-eng] [PATCH] printf -> mp_msg conversion (etc.), second patches

[Attila Kinali]

On Wed, Aug 18, 2004 at 04:57:58PM -0400, The Wanderer wrote:
> A little more work on the conversion. These patches cover mplayer.c, and
> assume that the syntax-change patch from the previous set has not been
> applied but that the others have.
> 
> 
> The first patch defines the new MSGTRs in help/help_mp-en.h.
> 
> The second patch removes all functional printfs from mplayer.c.
> 
> There are a number of strings not moved to the help file, primarily
> those in the OSD section - largely because I can't come up with a
> consistent and sane way of naming the MSGTRs, plus most of them are of
> the ("foo %s bar", x ? "baz" : x) form and so the additional word would
> not be translated anyway.

Leave them for teh moment, OSD needs to be remodeled anyways.

> I feel like I'm leaving something out, but I can't think what; if anyone
> else figures it out, please do tell me.
  
> -  if(how) mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_Exiting,mp_gettext(how));
> -  mp_msg(MSGT_CPLAYER,MSGL_DBG2,"max framesize was %d bytes\n",max_framesize);
> +  if(how) mp_msg(MSGT_CPLAYER,MSGL_INFO,MSGTR_ExitingHow,mp_gettext(how));
> +  mp_msg(MSGT_CPLAYER,MSGL_DBG2,MaxFramesizeWas,max_framesize);

Please dont add DBG2+ to the help-*.h, they are of no use for the casual
user but create unnecessary work for the translators as these messages
should always be printed in english.


>      case MP_CMD_EDL_MARK:
>        if( edl_fd ) {
>  	float v = sh_video->pts;
> +	// how to do this with mp_msg? define MSGT_EDL?
>  	fprintf( edl_fd, "%f %f %d\n", v-2, v, 0 );

Not at all, that's for edl output, which isnt exactly translatable :)


			Attila Kinali