[MPlayer-dev-eng] [PATCH] FreeBSD DVD Fix

[Diego Biurrun]

jb13 at gomerbud.com writes:
> On Fri, Aug 20, 2004 at 11:17:54AM +0200, Diego Biurrun wrote:
> > jb13 at gomerbud.com writes:
> > > On Thu, Aug 19, 2004 at 06:34:19PM +0200, Diego Biurrun wrote:
> > > > jb13 at gomerbud.com writes:
> [...]
> > > if netbsd ; then
> > >   for i in LDFLAGS; do
> > >     LDFLAGS=`echo LDFLAGS | sed 's,-L\(.* \),-L\1 -W\,-R\1,g'`
> > >   done
> > > fi
> > > 
> > > not tested
> > 
> > Why not send in a tested patch then ;-)
> 
> here you go

:-)

> --- configure	20 Aug 2004 18:29:25 -0000	1.902
> +++ configure	21 Aug 2004 09:12:31 -0000
> @@ -382,8 +382,11 @@
>      _inc_extra=-I`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -I,g'`
>      ;;
>    --with-extralibdir=*)
> -    _ld_extra=-L`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -L,g'`
> -#    _ld_extra="${_ld_extra} -Wl,-R"`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -Wl\,-R,g'`" -L"`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -L,g'`
> +    if [ $(uname -s) = "NetBSD" ]; then

Why not simply "if netbsd; then" like below?

> +      _ld_extra=`echo $ac_option | cut -d '=' -f 2 | sed -e 's,[a-zA-Z0-9/\\]*, -L& -Wl\,-R&  ,g' -e 's/ : //g'`

Do you really pass -L& and -R& on the command line?  This looks like
it would do funny things to me...

> +      if netbsd; then
> +        _ld_x11="-L$I -Wl,-R$I"
> +      else
> +	_ld_x11="-L$I"
   ^^^^

You have used a tab here and spaces above, please settle for one so
that the indentation is consistent.

Diego