[MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

Joey Parrish joey at nicewarrior.org
Sat Aug 21 00:16:20 CEST 2004


On Fri, Aug 20, 2004 at 09:35:09PM +0200, Torinthiel wrote:
> On Fri, Aug 20, 2004 at 12:03:04PM -0500, Joey Parrish wrote:
> > > Other thing is that you've now stripped TOO MUCH from vstream/Makefile.
> > > depend does nothing. And it should include top-level config.mak, at
> > > least to select correct optimization.
> > 
> > Okay.  The only thing depend did before was check deps for test.c, which
> > is now gone.  I'll fix depend.
> 
> Not exactly. It checked deps for all the sources.
> Quote from 11.tivo.patch
> +depend:
> +	$(CC) -MM $(CFLAGS) test.c $(SRCS) 1>.depend
> So all the sources are in the process.

My mistake.  I stand corrected.

> > There's really no need for an awk file to create prototypes for us.
> > Especially not in CVS.  I'll fix proto.h before next version.
> 
> Ok, either way is fine with me if it works. Even rm -f proto.h ;)

Well, proto.h is updated in my tree regardless.
Depend fixed as well.

Are there any other issues?

--Joey

-- 
"Are disorders necessarily bad?" --Ike




More information about the MPlayer-dev-eng mailing list