[MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

[César Ramos]

Don't work in mingw.
Error:
In file included from mfs.c:7:
mfs.h:9:17: pwd.h: No such file or directory
mfs.h:17:23: sys/ioctl.h: No such file or directory
mfs.h:24:24: sys/socket.h: No such file or directory
mfs.h:25:24: netinet/in.h: No such file or directory
mfs.h:26:19: netdb.h: No such file or directory
mfs.c: In function `vstream_mfs_resolve':
mfs.c:491: warning: assignment makes pointer from integer without a cast
mfs.c:491: warning: assignment makes pointer from integer without a cast
make: *** [mfs.o] Error 1


-----Mensaje original-----
De: mplayer-dev-eng-bounces at mplayerhq.hu
[mailto:mplayer-dev-eng-bounces at mplayerhq.hu] En nombre de César Ramos
Enviado el: viernes, 20 de agosto de 2004 21:21
Para: mplayer-dev-eng at mplayerhq.hu
Asunto: RE: [MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

Don't work in mingw


-----Mensaje original-----
De: mplayer-dev-eng-bounces at mplayerhq.hu
[mailto:mplayer-dev-eng-bounces at mplayerhq.hu] En nombre de Diego Biurrun
Enviado el: viernes, 20 de agosto de 2004 19:56
Para: mplayer-dev-eng at mplayerhq.hu
Asunto: Re: [MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

Joey Parrish writes:
> 
> I also added to the english xml DOCS

Nit1: You use American style two spaces between sentences, while the
docs uses European style one space.

Nit2: You add a bit of trailing whitespace here and there.

  +.B mplayer
  +'in +\n[.k]u
  +.I tivo://host/list
  +[options]
  +.br
  +.in
  +.B mplayer
  +'in +\n[.k]u
  +.I tivo://host/llist
  +[options]
  +.br
  +.in
  +.B mplayer
  +'in +\n[.k]u
  +.I tivo://host/fsid
  +[options]
  +.br
  +.in

What's the difference between these URL types?

  +  TiVo.  For more information on TiVo stream format, please refer to
  +  <ulink url="http://dvd-create.sourceforge.net/tystudio/tystream.shtml">
  +  this page</ulink>.

I'd say "the TiVo stream" and labelling links with "this" or "this
page" is bad style.  Please use something more descriptive like
"TyStudio page" or similar.

  +/* zone size in sectors */
  +u32 vstream_mfs_zone_size(int zone)
  +{
  +	return zones[zone]->zone_size;
  +}
  +


  +    /* reenable swapping */
  +    vstream_io_need_bswap(save_need_bswap);
  +
  +    return count;
  +}
  +


Are these ^L purposefully added there?  What for?

Diego

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng at mplayerhq.hu
http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng at mplayerhq.hu
http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng