[MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

Diego Biurrun diego at biurrun.de
Fri Aug 20 19:56:17 CEST 2004


Joey Parrish writes:
> 
> I also added to the english xml DOCS

Nit1: You use American style two spaces between sentences, while the
docs uses European style one space.

Nit2: You add a bit of trailing whitespace here and there.

  +.B mplayer
  +'in +\n[.k]u
  +.I tivo://host/list
  +[options]
  +.br
  +.in
  +.B mplayer
  +'in +\n[.k]u
  +.I tivo://host/llist
  +[options]
  +.br
  +.in
  +.B mplayer
  +'in +\n[.k]u
  +.I tivo://host/fsid
  +[options]
  +.br
  +.in

What's the difference between these URL types?

  +  TiVo.  For more information on TiVo stream format, please refer to
  +  <ulink url="http://dvd-create.sourceforge.net/tystudio/tystream.shtml">
  +  this page</ulink>.

I'd say "the TiVo stream" and labelling links with "this" or "this
page" is bad style.  Please use something more descriptive like
"TyStudio page" or similar.

  +/* zone size in sectors */
  +u32 vstream_mfs_zone_size(int zone)
  +{
  +	return zones[zone]->zone_size;
  +}
  +

  +    /* reenable swapping */
  +    vstream_io_need_bswap(save_need_bswap);
  +
  +    return count;
  +}
  +

Are these ^L purposefully added there?  What for?

Diego




More information about the MPlayer-dev-eng mailing list