[MPlayer-dev-eng] [PATCH] tivo vstream with DOCS

[Joey Parrish]

On Fri, Aug 20, 2004 at 10:11:37AM +0200, Torinthiel wrote:
> On Thu, Aug 19, 2004 at 07:57:15PM -0500, Joey Parrish wrote:
> > Are there any other suggestions or comments?  May I commit this soon?
> 
> Now only three from me.
> I'm not sure if the test if vstream/Makefile exists is a good test for
> building with/without vstream. Ok, I know I shouted on v1 that there was
> no test at all, but that was because I'm not sure (I don't want to dig
> into the code) if it will build regardless of anything. If yes, then no
> test is perfectly fine.

I'm doing the same thing mpdvdkit does, check for Makefile.  There are
no external deps for vstream.

> Other thing is that you've now stripped TOO MUCH from vstream/Makefile.
> depend does nothing. And it should include top-level config.mak, at
> least to select correct optimization.

Okay.  The only thing depend did before was check deps for test.c, which
is now gone.  I'll fix depend.

> Also, the file vstream/proto.h states it's autogenerated when you type
> "make proto". I remember that there was an awk file not linked to any
> usage which probably was for this. I wonder (I'm not sure which is
> easier/better) if it's better to include the file, or to enhance
> Makefile and add *.awk to generate the file automagically.

There's really no need for an awk file to create prototypes for us.
Especially not in CVS.  I'll fix proto.h before next version.

--Joey

-- 
"Living in the complex world of the future is somewhat
like having bees live in your head.  But, there they are."