[MPlayer-dev-eng] [PATCH] vo_xv: fix black screen in fullscreen

[Marko Macek]

Hello!

I am the author of icewm window manager

A bug has been sitting for a while in icewm bug database regarding black 
screens
when desktops are switched while the movie is played in fullscreen.
Black screen also occured in gmplayer when the movie is clicked to bring
it into the foreground.

https://sourceforge.net/tracker/index.php?func=detail&aid=909024&group_id=31&atid=100031

My card is R200 (radeon 9000)

The problem seems to be caused by a race condition between 
AUTOPAINT_COLORKEY
and this code in handle_events:

-    if (e & VO_EVENT_EXPOSE && vo_fs)
-        vo_x11_clearwindow(mDisplay, vo_window);

This sometimes causes color-key to be erased and the movie is invisible.

The attached patch fixes this. It is careful to only paint either the 
background
(black stripes when in fullscreen) or the color-key and not both over 
the same pixels
(prevents blinking on resize). Also fixed is ugly flicker when one drags 
a window over
(lowered) fullscreen window.

This with the latest CVS icewm (to fix a stupid aspect bug in icewm) 
makes 'mplayer'
fullscreen behave absolutely _perfectly_ (using _NET_WM_STATE_FULLSCREEN).

/me very happy.

Please test/comment and consider for 1.0.

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MPlayer-20040810-xv-noblackscreen.diff
Type: text/x-patch
Size: 12794 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040811/a34c05b6/attachment.bin>