[MPlayer-dev-eng] [PATCH] JPEG video output to multiple subdirectories v2

[Ivo]

On Monday 09 August 2004 14:28, Attila Kinali wrote:
> > +int jpeg_maxfiles=1536;
>
> BTW: where does this odd number come from ?
> Any reason not to use something like 1000 or 5000 ?

No, not really. 1536 is a number I frequently use since the eighties. It's 
exactly six pages on a 6502 CPU :)  I'll change it to something more 
decimal.

> > +     perror("This error has occurred:");
>
> Use strerror and pass the string to mp_msg

I'll change that.

> > +     mp_msg(MSGT_VO, MSGL_ERR, "%s: Unable to access %s\n",
> > info.short_name, buf); +     mp_msg(MSGT_VO, MSGL_ERR, "%s: No output
> > will be written to disk.\n", info.short_name);
>
> Can you put those strings into mp-help ? so they can be translated.
> Please also check whether some old msgs could be recycled.

I'm not completely familiar with the MPlayer codebase yet and wasn't aware 
of this functionality. I will look into it tonight.

> > +/* The jpeg_output_enabled flag can be used to disable the JPEG output
> > while + * the vo_jpeg module is already initialized and running. This
> > may be needed + * if, for example, file or directory creation fails
> > along the way. + * It defaults to 1, which means output is written. */
>
> Bad idea. If something fatal happends, and i call the inability to
> create a directory something fatal, then MPlayer should imediatly
> fail and thus exit with an error code. Letting MPlayer run and thus keep
> the image of everything being ok is the wrong way (and not user
> friendly).

Ok. Agreed. Is there a prefered way to exit the program (i.e. some cleanup 
function) or can I just call exit() ?

--Ivo