[MPlayer-dev-eng] FreeBSD patches review

[Daniel Eischen]

On Mon, 9 Aug 2004, [ISO-8859-1] Reimar Döffinger wrote:

> > http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/mplayer/files/patch-libdha-Makefile?rev=1.2&content-type=text/plain
> > 
> > All it does is change the libdha version string in lib filename. Probably
> > some FreeBSD naming convention. Doesn't look important.
> 
> I guess we don't care about names around here ;-)

Can you #ifdef it so that it obeys the FreeBSD convention?

> > http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/multimedia/mplayer/files/patch-libmpdvdkit2-dvd_reader.c?rev=1.1&content-type=text/plain
> > 
> > Looks completely unnecessary.
> 
> > --- libmpdvdkit2/dvd_reader.c.orig	Sat Aug  9 16:12:35 2003
> > +++ libmpdvdkit2/dvd_reader.c	Fri Oct  3 18:16:43 2003
> > @@ -239,6 +239,11 @@
> >     Darwin  /dev/rdisk0,  it needs to be the raw device
> >     BSD/OS  /dev/sr0c (if not mounted) or /dev/rsr0c ('c' any letter will do) */
> >  static char *bsd_block2char( const char *path )
> > +#if defined(__FreeBSD__)
> > +{
> > +    return (char *) strdup( path );
> > +}
> > +#else
> >  {
> >      char *new_path;
> >  
> > @@ -253,6 +258,7 @@
> >  
> >      return new_path;
> >  }
> > +#endif /* __FreeBSD__ */
> >  #endif
> >  
> >  dvd_reader_t *DVDOpen( const char *path )
> 
> I don't know. Some lines above it says: FreeBSD /dev/(r)(a)cd0c (a is 
> for atapi), recomended to _not_ use r

There are no 'r' devices in FreeBSD-5 any longer.

> Those block2char functions look quite dubious to me anyway... can anyone 
> explain why they are needed?
> 

-- 
DE