[MPlayer-dev-eng] [PATCH] FreeBSD DVD Fix

[Daniel Eischen]

On Sun, 8 Aug 2004, Bernd Ernesti wrote:

> On Sun, Aug 08, 2004 at 11:32:49AM -0400, Daniel Eischen wrote:
> [..]
> > ???  Well, here's a set of FreeBSD patches for mplayer 0.99.5:
> > 
> >   http://www.freebsd.org/cgi/cvsweb.cgi/ports/multimedia/mplayer/files/
> > 
> > Some of those patches are to get it to build and install
> > properly in our environment based on how our ports system
> > works.
> > 
> > The next time the port is updated to a newer version of mplayer,
> > I'll resend you the same link.
> 
> Such a thing is kind of useless.
> How would you expect that a mplayer developer knows which patch
> if port only and would break a non port build?

Look at them - the patches are very small and there are only 8
or 9 of them.  Also, do you not wish to know how mplayer is
being installed?  Is it not feasible that you might want to
make it easier for other OSs to build and install out of
the box so that all the pieces parts get installed where
the platform wants them to go instead of where mplayer
wants to put them by default?

> It's up to you to feed back changes and not expect someone else to
> pull them. Like it is documented in the mplayer docs.

I find it ironic that you would give preference to bugs filed
without any patches than to a set of posted patches which
you refuse to look at just because they were not copied
from the link and pasted into an email.

> And http links tend to vanish from time to time, so you can't verify
> after some time that the change which was done, was the same which
> was intended to be integrated. Not to mention that someone could
> make new changes and at one point it breaks something and just at
> that time someone looks at that page, get the patch and integrate it.

That link has been there for almost 3 years.  The files within it may
have changed over time, but that is because the port is specific
to one version of mplayer.  The latter part seems like a bit of
nonsense.  Patches can arrive on the mailing list at random
just like someone can look at the link for patches at random.
Coordination of fixes is needed regardless of where the patches
originate.

> I can only hope that you are not the freebsd port maintainer for mplayer.

I am not.  That said, I have had to fix mplayer only once before
for ldt allocation.  I sent the patch to the port maintainer and
he told me to post it here.  I had to subscribe to this list
in order to post it.  I posted it and it got incorporated.

But the fact that we're having this dialog is due only to
me having to subscribe to the list in the first place.

I'll shut up now.  If you choose to look over the patches or not
is up to you.  Regardless, I thank the developers for giving us
mplayer :)

-- 
DE