[MPlayer-dev-eng] [PATCH] FreeBSD DVD Fix

[Daniel Eischen]

On Sun, 8 Aug 2004, Dominik 'Rathann' Mierzejewski wrote:

> On Saturday, 07 August 2004 at 06:45, rcooley wrote:
> > On Sat, 7 Aug 2004 10:48:46 +0900
> > Attila Kinali <attila at kinali.ch> wrote:
> > 
> > > I've meet too many bsd users who just use gpl or gnu code until they
> > > hit a bug. Then the workaround it or use something else.
> > 
> > Well, BSD users are rather accustomed to being neglected/ignored,
> > espcially with all the Linux-specific software out there.  I think it's
> > just a conditioned response at this point.
> > 
> > > Or take MPlayer as an example, most bsds have huge ports patches,
> > > although MPlayer is supposed to compile out of the box. Noone of them
> > > were send upstream until we asked explicitly for them.
> > 
> > This is quite interesting...  First of all, NONE of the FreeBSD patches
> > I sent were applied.  That should tell you something.
> 
> Yes, it does. Maybe they were all *crap*? Have you considered that?

Regardless of whether they are crap or not, they are meant to
show you a problem and a potential work-around.  You can't
expect to get handed perfect patches from non-mplayer developers
(do you always get perfect patches from yourselves?).
It's up to the developers to look at the patch, decide whether
it is really a problem, and provide the "correct" solution.

> > Also, the only request I saw was AFTER the OpenBSD patches were already
> > sent...  I wouldn't have even thought to send in the patches, if not for
> > the request, because they are all easily available to anyone via CVS
> > (or CVS-Web).
> 
> Oh, and MPlayer devs should check there every now and then and see if
> there's perhaps something worth applying, yes? No. If you have a patch,
> you send it to the author, rather than expect the author go looking for
> it.

And noone has ever posted patches via a link:

  * I have this problem with mplayer, but I came up with the
  * following patch that fixes it:
  *
  *   http://people.foo.bar/~user/mplayer.patch

???  Well, here's a set of FreeBSD patches for mplayer 0.99.5:

  http://www.freebsd.org/cgi/cvsweb.cgi/ports/multimedia/mplayer/files/

Some of those patches are to get it to build and install
properly in our environment based on how our ports system
works.

The next time the port is updated to a newer version of mplayer,
I'll resend you the same link.

-- 
DE