[MPlayer-dev-eng] [PATCH]demus_asf.c : ASF video not playing

[Torinthiel]

On Tue, Jun 22, 2004 at 04:27:38PM +0200, alexis.deruelle wrote:
> 
> 
> There's a bug in libmpdemux/asf_demux.c that prevents some videos
> (grabbed with my digital camera) from playing.
> 
> The packet pointer calculation at the begining of demux_asf_fill_buffer
> is broken IMHO, the logic tries to adjust the pointer value with the
> size of optional ECC info.
> 
> The simple patch below fixes it for me (against current CVS snapshot) :
> 
> --- demux_asf.c.orig    2004-06-22 15:54:32.160990833 +0200 
> +++ demux_asf.c 2004-06-22 16:08:26.311748475 +0200
> @@ -153,7 +153,7 @@
>      if(demux->stream->eof) return 0; // EOF
> 
>      {      unsigned char ecc_flags=asf_packet[0];
> -           unsigned char* p=&asf_packet[1+(ecc_flags&15)];
> +           unsigned char* p=asf_packet;
>              unsigned char* p_end=asf_packet+asf_packetsize;
>              unsigned char flags=p[0];
>              unsigned char segtype=p[1];
> 
> If no ECC is present, there's no need to offset the ponter at all.
> moreover the offset
> 
> What do you think ?

Any comments?
And please, don't put patches in the middle of the text.
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040804/72adf6cc/attachment.pgp>