[MPlayer-dev-eng] [PATCH] Complete libmpdvdkit cruft removal

Diego Biurrun diego at biurrun.de
Mon Aug 2 05:31:51 CEST 2004


eviv bulgroz writes:
> Diego Biurrun wrote:
> 
> >eviv bulgroz writes:
> >
> >>Here is a patch to complete the libmpdvdkit/libmpdvdkit2 cruft removal.
> >
> >Rejected.
> >
> >I don't like this patch.  The tests are kept there in case somebody
> >adds libmpdvkit (the first version) to his tree for whatever reason,
> 
> >  Still, renaming everything to mpdvdkit when the directory is
> >called libmpdvdkit2 is just obfuscation IMHO.  So removing the old
> >tests/variables might be OK as it's basically cruft, but renaming is
> >not.
> 
> Here is another patch with less renaming ...

Still too much renaming for my taste.  Why don't you just remove the
references to mpdvdkit and keep mpdvdkit2 without the renaming?

Diego




More information about the MPlayer-dev-eng mailing list