[MPlayer-dev-eng] [PATCH] Complete libmpdemux cruft removal

Diego Biurrun diego at biurrun.de
Sun Aug 1 01:50:49 CEST 2004


eviv bulgroz writes:
> Here is a patch to complete the libmpdemux/libmpdemux2 cruft removal.

Rejected.

I don't like this patch.  The tests are kept there in case somebody
adds libmpdvkit (the first version) to his tree for whatever reason,
although I have no idea if it would still work and I doubt it is
useful.  Still, renaming everything to mpdvdkit when the directory is
called libmpdvdkit2 is just obfuscation IMHO.  So removing the old
tests/variables might be OK as it's basically cruft, but renaming is
not.

Diego




More information about the MPlayer-dev-eng mailing list