[MPlayer-dev-eng] Re: [PATCH] fix for issue cant play filenames with spaces

[Roberto Togni]

On 2004.04.29 23:38, adland wrote:
> >  - unescape url before escaping it
> 
> I tried testing this change alone and it does not work due to a  
> double
>  escapeing issue.
> 
> and the escape url function is now broken.
> 
> %20 or space
> becomes
> %2520
> which fails at the server
>
hmm, the thing is more complex than i first tought.
My patch fix escaping the url, but looks like the url is escaped again  
elsewhere before being put on the http GET command. So it's not useful  
at all in this situation.


So we have:
 - my patch fix escaping of already escaped url for protocols that  
don't change the url anymore (ex. realrtsp)
 - url are still broken for http, because they get escaped again while  
doing http protocol.

How do other protocols behave (mms and such)?

So i think we have two solution:
1. unescape urls before escaping them everywhere in the code (better  
doing it in url_escape_string)
2. modify url_escape_string to avoid escaping of escape sequences, like  
adland did.

Bertrand, which one do you like best? Any other proposal?


The other fixes are not so important, they're there because i modified  
my local copy of the file and didn't want to reverse them when making  
the diff. I'll apply them whet the main problem is fixed.

Ciao,
 Roberto