[MPlayer-dev-eng] [PATCH] [RESEND] fix -playlist issue

Roberto Togni r_togni at tiscali.it
Thu Apr 15 21:37:44 CEST 2004


On 2004.04.15 02:55, adland wrote:
> Resend of previous patch updated for intermediate CVS
> code changes.
[...]
> +++ updated/libmpdemux/open.c	2004-04-14 00:54:19.000000000
> -0400
> @@ -115,7 +115,12 @@
>  stream_t* stream=NULL;
>  int f=-1;
>  off_t len;
> -*file_format = DEMUXER_TYPE_UNKNOWN;
> +
> +  // Check if playlist or unknown
> +  if (*file_format != DEMUXER_TYPE_PLAYLIST){
> +    *file_format=DEMUXER_TYPE_UNKNOWN;
> +  }
> +
while relloking at this patch, something catched my attention.
I fear there are places (like in asxparser.c and mencoder.c) where  
open_stream get called with file_format not defined, something like:

int f;
open_stream(.... , &f);

In these cases you end up checking the value of an unassigned variable.
I think it would be better to assign it everywhere to  
DEMUXER_TYPE_UNKNOWN

Can you please take a look at it?

Ciao,
 Roberto




More information about the MPlayer-dev-eng mailing list