[MPlayer-dev-eng] Re: [PATCH] loader compiler warnings

[adland]

question?

#ifdef QTX
    FF(WaitForMultipleObjects, -1)
    FF(ExitThread, -1)
    FF(CreateMutexA,-1)
    FF(ReleaseMutex,-1)
#endif

static HANDLE WINAPI expCreateMutexA(void *pSecAttr,
                    char bInitialOwner, const char *name)
{
  .. code removed ...
#ifndef QTX
    /* 10l to QTX, if CreateMutex returns a real mutex, WaitForSingleObject
       waits for ever, else it works ;) */
    return mlist;
#endif
}

as coded
would this QTX not always be defined when function is exported
so unsure why there is an ifndef QTX?

you suggested adding #else
                      return (HANDLE) NULL:
                      or then
                      return 0;

the wine code always returns a HANDLE
if you look in /dlls/kernel/sync.c

CreateMutexA and CreateMutexW

code becomes;

static HANDLE WINAPI expCreateMutexA(void *pSecAttr,
                    char bInitialOwner, const char *name)
{
   if (name)
        dbgprintf("CreateMutexA(0x%x, %d, '%s') => NULL",
            pSecAttr, bInitialOwner, name);
    else
        dbgprintf("CreateMutexA(0x%x, %d, NULL) => NULL",
            pSecAttr, bInitialOwner);

   return (HANDLE) NULL;
}

change is no need to create a mlist as it is not used

please comment