[MPlayer-dev-eng] Re: [PATCH] loader compiler warnings

[adland]

> > 
> > see wine code
> > in dlls/kernel/path.c function is defined as
> > DWORD WINAPI GetFullPathNameA( LPCSTR name, DWORD len,
> > LPSTR buffer, LPSTR *lastpart )
> 
> It doesn't matter what's in wine. Our loader comes from avifile.

this function to my knowledge is only called by external win32 dll files.
why would you not want to match wine (which avifile loader was based on).

> IMHO it's unacceptable, because it actually changes/removes loader code.

your previous statement was confusing. see below

[quote]
>This is our code (not in avifile's loader), so we may mess with it. ;)

now I have downloaded and looked at avifile source for this file
avifile/plugins/libwin32/loader/win32.c

I see that function does exist here as well with same old format.

looks like we would want that they are also syncing from us 
if we have changes to file.

note I have submitted several patches with changes to this file
 which I have no idea if they are synced in avifile or not.

> Remember, our loader comes from avifile, so any change to original code
> means rejected hunks when syncing with avifile's loader. Besides, your
> patch does basically the same as mine, so what's the improvement?
> 

yes it is simmilar. 

small difference
-matching the wine/windows format for this function.
-removing some old #if 0 code which is not needed

please comment
thank you