[MPlayer-dev-eng] url.c (maybe) 10l bug

Bertrand Baudet bertrand_baudet at yahoo.com
Wed Apr 7 00:29:10 CEST 2004


On Tuesday 06 April 2004 14:17, Alex Beregszaszi wrote:
> Hi,
>
> > the upper block accepts '%' as-is unescaped, but the lower block then
> > uses '%' to escape special chars. i guess that '%' should be escaped
> > too...
> >
> > or maybe the '%' is allowed here to let this function work on already
> > escaped URIs? it makes sence, but still has a buggy side-effect on
> > unescaped strings containing '%' char...
> >
> > if no objection, Attila or Diego will commit a fix :))
>
> Any fixes on this? Bertrand, please comment!

Looks like Arpi is right.

From the RFC 1738:

"The character "%" is unsafe because it is used for encodings of other 
characters."
And
"All unsafe characters must always be encoded within a URL."

I'm going to commit a fix tomorrow.

Bertrand




More information about the MPlayer-dev-eng mailing list