[MPlayer-dev-eng] Re: [PATCH] remove compile warnings from dshow

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Mon Apr 5 00:05:14 CEST 2004


On Thursday, 01 April 2004 at 21:03, adland wrote:
>  
> > AFAIR there was some argument by A'rpi about fixing it properly to use
> > arch-independent inttypes, but he rejected my patch changing long, int and
> > some DWORD types into appropriate intxx_t types saying something about
> > sync trouble. Never mind.
> 
>  I dont understand need to make something platform independant here.
> 
>  if you look at the change it is just for one thing:
>  change the typedef ULONG into its value unsigned long
>  no real changes (ULONG == unsigned long)  but it makes a cleaner build.
>  
>  I dont see what the controversy about it is.

In original avifile win32 loader sources this was so, but in MPlayer
A'rpi changed ULONG and DWORD from long to int, because of some non-x86
platform trouble. I'm almost done working on a patch that reverses this
and introduces changes that A'rpi himself wanted to do.

Changes to loader/ are minimal.

-- 
MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer.html
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"




More information about the MPlayer-dev-eng mailing list