[MPlayer-dev-eng] osdep/fseeko.c ifndef sense reversed?
Steven M. Schultz
sms at 2BSD.COM
Sun Apr 4 17:08:55 CEST 2004
On Sun, 4 Apr 2004, Sascha Sommer wrote:
> > int fgetpos(FILE *stream, fpos_t *pos);
> > int fsetpos(FILE *stream, fpos_t *pos);
> >
>
> No manpage here.I only searched google and the reference I looked at defined
> them with off_t.
> MINGW32 doesn't need off_t instead of fpos_t. The original code had off_t
> instead of fpos_t and
> I didn't want to break other systems.
Ah, ok - I see.
If off_t was originally used in those two places that was a mistake
on my part.
> I will reverse then and change it to fpos_t.
Or just change the off_t to fpos_t for all cases (no #ifdef) - I think
that will work fine and avoid the problems caused by 'typedef off_t fpos_t'.
This module is for compatibility only - systems which have ftello/fseeko
will not use osdep/fseeko.o (or rather fseek.o will be empty).
Thanks!
Steven Schultz
More information about the MPlayer-dev-eng
mailing list