[MPlayer-dev-eng] [PATCH] remove compile warnings from dshow

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Thu Apr 1 18:04:18 CEST 2004


On Thursday, 01 April 2004 at 17:55, D Richard Felker III wrote:
> On Thu, Apr 01, 2004 at 02:09:47PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > On Thursday, 01 April 2004 at 09:12, adland wrote:
> > > patch to remove compiler warnings from dshow
> > 
> > Hey, compiler warnings are _my_ turf! ;)
> > 
> > Besides, if you check the archives, I already submitted a similar patch
> > last year and it was rejected, because that code comes from avifile
> > and patching it in this way will make synchronization more difficult.
> 
> Nonsense, the code has diverged so much it'll never be synced...

AFAIR there was some argument by A'rpi about fixing it properly to use
arch-independent inttypes, but he rejected my patch changing long, int and
some DWORD types into appropriate intxx_t types saying something about
sync trouble. Never mind.
So you're implying it might be worthwile to try that patch again?
I'll resend it then.

-- 
MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer.html
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"




More information about the MPlayer-dev-eng mailing list