[MPlayer-dev-eng] None

[Diego Biurrun]

"Michael A Baikov"  writes:
 > PS If this edition of filter will be commited, please, fix language mistakes
 > in man file ;)

Here comes my review..  Please resend your patch after fixing the
mistakes with [PATCH] in the subject, else it will most probably be
lost.

First some general comments.

- Please add your filter description after the hqdn3d filter and not
  at the end of the list.  I'm trying to put the filters into a
  somewhat more logical order.

- One parameter is called param.  This is bad, it does not help in
  understanding what it does.  Please try to come up with a more
  descriptive name.

- You misspelled "weigHT" as "weigTH". "dual pass" should be two
  words, not one.


- Sentences should start with capitals and end in a colon.

Thanks

Diego


--- main/DOCS/en/mplayer.1	2003-09-06 13:51:30.000000000 +0400
+++ build/DOCS/en/mplayer.1	2003-09-14 18:55:12.000000000 +0400
@@ -3050,6 +3050,29 @@
 Thickness of the fuzzy edge of the rectangle (added to w and h). When
 set to -1, a green rectangle is drawn on the screen to simplify finding
 the right x,y,w,h parameters.
+.RE
+.TP
+
+.B hqdnsm[=threshold[:radius[:param:zeroweigth[:threshold2]]]]
+High Quality 2D Smooth Denoiser filter. This filter is good for elminating

I would not capitalize all those words, they do not match the order of
HQDNSM anyway and I would use denoise_ instead of denoiseR

el_I_minating

+pixel-sized (less than 3-5 pixels width) noise.

Hmm, is it pixel-sized or bigger?  I would suggest using "near
pixel-sized" here.

+.PD 0
+.RSs
+.IPs threshold
+should be in range 1..127,  15 is a good start for single pass encoding. For

Values can be 1 \- 127, 15 is a good start for single pass encoding.

+dualpass, this value must be less. Large values can (and will) cause some
+artifacts at left and right borders of the screen.

.. at the left ..

+.IPs radius
+7 is good enougth for most purposes. If radius is equals to zero, 2D filter

enouGH

"is equal_ to" or "radius equals zero", but I would just say "If
radius is 0, _the_ 2D filter .."

+works as 1D ;) More than 7 is waste of CPU resources

.. is a waste of ..

+.IPs param
+image will be more blured for larger param. param may be negative. Default value is

bluRRed

What is the range of the parameter?  You should say this.

+200. Values should be greater than 100 or less than -100.
+.IP zeroweigth
+weigth of central pixel. Default value is 160

For consistency with the rest of the man page:

  weight of central pixel (default: 160)

+.IP threshold2
+set this parameter for dualpass filtrating. To obtain good results try

filTERing

+something like hqdnsm=5:5:10000:5000:10
 
 
 .SH "GENERAL ENCODING OPTIONS (MENCODER ONLY)"