[MPlayer-dev-eng] Re: [PATCH] 2 fixes for libmenu and one for x11_common.

Alban Bedel albeu at free.fr
Tue Sep 23 15:30:19 CEST 2003


Hi Dmitry Baryshkov,

on Tue, 23 Sep 2003 14:46:04 +0400 you wrote:

> Hello!
> Attached 3 patches:
> 1) fixes menu(libmenu) handling in paused mode. Also removes hack for
>   'pause not working first time' bug. It's no longer needed.
Pls don't apply this one. The bug is in fact a simple 10l, just add
priv->current->show in the if under the #if 0 and it's solved.
But currently this only allow to move in the menus so that's not
so useful.
But what i want to do since a long time is move the handeling of some
commands (mainly the playtree ones) out of the main loop to their own
function. This way these commands can also be handled in pause mode and
this hack in the menu become really useful (so you can pause, search a
new file in the menu and directly load it).
In fact i worked on this recently but i have too much differents stuff
under way atm ;( I'll post all my mess soon (stream stuff, goom, lavc
audio encoding and a new "mode" where mplayer doesn't quit at the end
of the playlist).

> 2) Fixes a known-for-long-time bug with handling down key in lists in
>    menu.
That look ok.

> 3) During fixing menu, I found that MPlayer doesn't get get some keys
>    (e.g. _,=,~ etc.) from Xv/X11 windows. Attached patch fixes it.
This too.

> If nobody objects, I'll probably commit them at next Monday (29.09).
You can safly commit the last 2.
	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.




More information about the MPlayer-dev-eng mailing list