[MPlayer-dev-eng] [PATCH] blackbar osd option + vo svga, vo_dgaNOVIRUS

[Dimitar Zhekov]

On Sat, 20 Sep 2003 02:41:32 +0300 (EEST), Ivan Kalvachev
<ivan at cacad.com> wrote:

> If you want to reject your patch then here it goes why:

>> --- libvo/vo_svga.c     2 Apr 2003 04:31:40 -0000
>> +++ libvo/vo_svga.c     17 Sep 2003 07:06:25 -0000
>> ...
>> -    rgbplane=PageStore[0].vbase + (y*mode_stride) +
>> +    rgbplane=PageStore[cpage].vbase + (y*mode_stride)
>> ...

> This part is from svga_clear_box, cpage is the current
> page [...] This means that cpage is undefine on config()
> time, and this function is used to [...] by config. The
> solution is to zero cpage ...

I checked this when writing bbosd: "static int cpage=0".
So in the 1st config() PageStore[0] <=> PageStore[cpage].
About the next config()-s, if any, I was unable to
recognize any "starting-2nd-3rd-...-movie-from-page-0
again" code; the problem may arise only if such code
exists but it doesn't reset cpage to 0 for some reason.

> The second problem is here:
>> ...
>> +    svga_clear_box(0, y_pos, x_pos, ...
>> +    svga_clear_box(modeinfo->width - x_pos, ...
>> ...
> x_pos is rounded by factor 16. This could leave visible
> part of subtitles (e.g. seek bar) ...

Sorry. Got used to < 1.0's vo_svga I guess...

> I see that the core developers prefer to reject your
> patch in favior of vf_expand. But I will incorporate
> this ability in the svga anyway.

Thanks... However, I decided to stick to 0.9x series for
ROCK-Linux, at least until 1.0x is fully cleaned up and
more useful IMVHO than 0.9x...

> I will also remove the separate page code in svga, as
> i had forgot how does it work and i couldn't understand
> that from the souce, and there is already better in G2

Reading G2 source code is beyond my skills... or wills.
But it seems obvious that the vo-s must be divided on two
distinct parts, video driver & frame driver (see libGRX),
and the video driver should _return_ it's list of modes.

-- 
E-gards: Jimmy