[MPlayer-dev-eng] [PATCH] blackbar osd option + vo svga, vo_dgaNOVIRUS

[Dimitar Zhekov]

A> why are you keep adding such hacks, insteda of rtfm'ing
A> about -vf expand ???

GSB> - would be easier to have one single flag to that.
GSB> -vf scale=800:-3,expand=800:600 isn't so friendly...

-vf scale... I use svga/dga primary to _avoid_ any movie
scaling, that's always a quality+cputime loss. And without
scale, you'd better know the best monitor resolution to
pass to -vf expand; even expand with negative values may
result in a higher resolution mode than needed for the
movie. So I don't wont to run each movie _twice_ to 1) see
the best monitor mode and 2) specify it to -vf expand.

Now in theory it might be possible to implement bbosd as
an expand filter after vo config has been performed, but
with such a late movie size change Bad Things Will Happen.

Even if mplayer is somehow(?!) "fixed" to work this way,
there will still be an unneeded slowdown if both vf expand
and bbosd expand are used, while with this patch they work
together nicely, with bbosd clearing the areas (if any)
outside the expanded area.

If you have don't have a better suggestion but still
reject the patch, I hope you won't be against including it
in the ROCK-Linux MPlayer package, so the 1st extended
(instead of crippled) mplayer may see the daylight, or
whatever all good programs see when being run.

A> with a vo driver supporting DR (get_image()) it will
A> have the same speed

Actually bbosd/expand always have the same speed for me,
except when expand doesn't work (that's faster :-)

IK> I can tell you that there is special function that
IK> clears subtitles (rectangulars) when needed. I used
IK> it in xvmc, you can take a look there.

>From what I see, xvmc uses XvMC*Subpicture() calls, which
are X11 only and non-DGA. vf_expand.c:remove_func() does
this, but it's for internal use by vf expand only.

-- 
E-gards: Jimmy